Skip to content

fix(views): ListView reads the spec-canonical filter, so a view's base filter reaches every visualization (#2890) - #2935

Merged
os-zhuang merged 1 commit into
mainfrom
feat/2890-listview-filter
Jul 28, 2026
Merged

fix(views): ListView reads the spec-canonical filter, so a view's base filter reaches every visualization (#2890)#2935
os-zhuang merged 1 commit into
mainfrom
feat/2890-listview-filter

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Third rename in #2890 scope A: filtersfilter. Unlike steps 1–2 this one closes a live bug, because the fork was asymmetric.

The bug

ListView was the only surface in the repo reading filters. Every child view reads filter:

component reads
ObjectGrid, ObjectGallery, ObjectKanban, ObjectCalendar, ObjectGantt, ObjectMap, ObjectTree, ObjectChart schema.filter
ListView schema.filters ← the odd one out

…and ListView handed its children filters. Wherever a child fetches its own rows instead of receiving ListView's, the view's base filter was silently dropped:

  • A chart list view aggregated the whole object. The chart branch built an object-chart node with filters:; ObjectChart reads schema.filter and never read filters, so a chart view with a base filter charted unfiltered totals.
  • Same for any of the other view components rendered standalone from a list-view-shaped config.

And in the other direction: a spec-authored list view — one carrying filter, which is what the spec says and what runtime-metadata-persistence and "Save as view" already persist — rendered unfiltered in ListView, because nothing read that key. The app-shell hosts only avoided this by converting filterfilters on the way in.

The fix

Folded in the same normalizeListViewSchema as steps 1–2, plus:

  • ListView reads schema.filter and emits filter to its children (grid path, chart path, and every baseProps consumer);
  • the four producers stop downgrading: plugin-view/ObjectView's renderListView payload, app-shell/ObjectView, InterfaceListPage, ObjectDataPage, and the list-view registry defaults.

Key rename only — no format conversion. Both keys carry an ObjectQL FilterNode array everywhere in objectui, and every consumer passes the value straight to $filter. Worth flagging separately: the spec types filter as ViewFilterRule[] ({field, operator, value} objects), so objectui's field is typed from the spec but used as something else. That mismatch is real; converting formats inside a vocabulary fold would change what reaches the data source, so it is documented in the normalizer and left alone.

Drive-by: one filter computation instead of two

app-shell's ObjectView built the same effective filter twice — once as filter for the child views, once ~140 lines later as filters for ListView — and the two copies had drifted: only the first fell back to listSchema.filter; only the second ran token substitution over the URL filters. There is now one computation that keeps both behaviors.

Verification

  • normalize-list-view.test.ts +4: fold, canonical-wins, verbatim value (compound ['and', …] nodes must not be rewritten), non-array passthrough.
  • ListView.test.tsx +3 consumer regressions asserting the $filter actually sent to the data source, from filter, from legacy filters, and with both present.
  • 320 test files / 3067 tests across core, types, plugin-list, plugin-view, plugin-grid, plugin-charts, app-shell pass; turbo run type-check 32/32; ESLint 0 errors.

🤖 Generated with Claude Code

Third rename in the ListView vocabulary migration: `filters` → `filter`. Unlike
the first two this closes a live bug, because the fork was asymmetric.

ListView was the ONLY surface reading `filters`. Every child view — ObjectGrid,
ObjectGallery, ObjectKanban, ObjectCalendar, ObjectGantt, ObjectMap, ObjectTree,
ObjectChart — reads `filter`, and ListView handed them `filters`. Wherever a
child fetches its own rows instead of receiving ListView's, the base filter was
dropped: a `chart` list view aggregated the whole object, because the chart
branch emitted `filters:` and ObjectChart reads `schema.filter`.

Conversely a spec-authored view carrying `filter` — what the spec says, and what
runtime-metadata-persistence and "Save as view" already persist — rendered
unfiltered in ListView, because nothing read that key.

Key rename only: both keys carry an ObjectQL FilterNode array everywhere in
objectui and every consumer passes the value straight to `$filter`. The spec
types `filter` as ViewFilterRule[], so the field is typed from the spec but used
as something else — noted in the normalizer, left alone here, since converting
formats inside a vocabulary fold would change what reaches the data source.

Also collapses a duplicated computation in app-shell's ObjectView, which built
the same effective filter twice (once as `filter` for the children, once as
`filters` for ListView) with the copies subtly different — only one fell back to
listSchema.filter, only the other substituted tokens in the URL filters. One
computation now, keeping both behaviors.

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 28, 2026 4:14pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-C659Y0Md.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.13KB 97.92KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 127.78KB 32.15KB
fields (index.js) 220.07KB 53.90KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 179.93KB 42.67KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.77KB 53.01KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.47KB 25.10KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 179.25KB 46.97KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.55KB 23.28KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.07KB 9.81KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.68KB 20.85KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.86KB 0.91KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit f1abf0e into main Jul 28, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the feat/2890-listview-filter branch July 28, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant